Deep extend when adding global query params in ufTable #1114
Conversation
At the moment if you were to use `addParams` to set a global `filter` or `sort` for a table, it would overwrite all other filters and sorts applied to the table. It doesn't seem like this was a deliberate design choice when `addParams` was introduced in 3159224. By using a deep extend instead, we can set global filters without overriding any sorts/filters set by the user. It does technically change the behavior, but I don't see a valid use case for the way it currently behaves.
|
Code looks fine, but I can't approve this. Merging options can be a deceptively complex process, as certain combinations of merged configurations can end up being invalid (which ends up requiring people passing configurations in having to explicitly specify more configuration options). To properly review this I've need to first figure out the shape of the configuration option and what those options are. |
|
@Silic0nS0ldier In general agree, but in this case the parameters are only merged into a very specific portion of the config options. Namely, the |
|
Since the base got messed up, I merged it manually in Hotfix: 3310530 |
At the moment if you were to use
addParamsto set a globalfilterorsortfor a table, it would overwrite all other filters and sorts applied to the table. It doesn't seem like this was a deliberate design choice whenaddParamswas introduced in 3159224. By using a deep extend instead, we can set global filters without overriding any sorts/filters set by the user. It does technically change the behavior, but I don't see a valid use case for the way it currently behaves.